Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Try to load Karton lazily if can't be loaded eagerly #919

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Feb 23, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

If MWDB can't load Karton producer on load time, it gives up completely and marks it as unavailable

What is the new behaviour?

When Karton is enabled, we try to load it on every request until it succeeds.

Test plan

Closing issues

related with #891

@psrok1 psrok1 marked this pull request as ready for review February 26, 2024 16:42
@psrok1 psrok1 merged commit b198501 into master Feb 27, 2024
12 checks passed
@psrok1 psrok1 deleted the fix/karton-lazy-loading branch February 27, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant